[PATCH] [msan] Refactor memory layout specification and setup

Alexander Potapenko glider at google.com
Tue Jan 27 05:14:01 PST 2015


LGTM with a nit.


================
Comment at: lib/msan/msan.h:39
@@ -51,9 +38,3 @@
 #if SANITIZER_LINUX && defined(__mips64)
-const uptr kLowMemBeg   = 0;
-const uptr kLowMemSize  = 0;
-const uptr kHighMemBeg  = 0x00e000000000;
-const uptr kHighMemSize = 0x002000000000;
-const uptr kShadowBeg   = 0x00a000000000;
-const uptr kShadowSize  = 0x002000000000;
-const uptr kOriginsBeg  = 0x00c000000000;
-# define MEM_TO_SHADOW(mem) (((uptr)(mem)) & ~0x4000000000ULL)
+
+const MappingDesc kMemoryLayout[] = {
----------------
Please add a "TODO(someone): add description" or ask Mohit for the description.

http://reviews.llvm.org/D7146

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list