[PATCH] Remove kindInGroup reference

Nick Kledzik kledzik at apple.com
Mon Jan 26 22:12:37 PST 2015


On Jan 26, 2015, at 8:10 PM, Rui Ueyama <ruiu at google.com> wrote:
> I think it's not for garbage collection. Because all atoms in the same section are already connected with LayoutAfter references, they are treated as a group by the garbage collector.
> 
Well, the first atom in the section has nothing before it, so it has nothing holding on to it.   

More generally, if all you have is a after-chain and the only atom referenced from outside the section is the Nth atom, then dead stripping could remove atoms 1 thru N-1.

-Nick



> 2015/01/26 19:25 "Shankar Easwaran" <shankar.kalpathi.easwaran at gmail.com>:
> This is mainly relevant when you turn on garbage collection as Nick pointed out. You can refer to an atom in a section but to keep the section to be consistent w.r.t ELF you have to keep all the remaining atoms together.
> 
> 
> http://reviews.llvm.org/D7189
> 
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150126/75317321/attachment.html>


More information about the llvm-commits mailing list