[PATCH] Avoid combining adjacent stores at -O0 to improve debug experience

Jim Grosbach grosbach at apple.com
Mon Jan 26 18:26:13 PST 2015


> On Jan 26, 2015, at 6:15 PM, Chandler Carruth <chandlerc at google.com> wrote:
> 
> 
> On Mon, Jan 26, 2015 at 3:09 PM, Jim Grosbach <grosbach at apple.com <mailto:grosbach at apple.com>> wrote:
> There should be exactly zero DAG combines that have to run, ever. They are by definition not required for correctness. Anything else is a bug, and a bad one.
> 
> The X86 backend at least heavily uses target-specific DAG combines to "lower" DAG nodes that it doesn't have any actual lowering for.
> 
> Yes, it's a bug. But I don't even know how much work would be required to fix it.

Yeah, I certainly don’t claim our backends are bug free, especially with regards to things like this where we’re not actively testing for it. I would just like to be actively moving things forwards when we have the opportunity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150126/87f45576/attachment.html>


More information about the llvm-commits mailing list