[llvm] r227149 - Commoning of target specific load/store intrinsics in Early CSE.

Chandler Carruth chandlerc at google.com
Mon Jan 26 17:16:40 PST 2015

On Mon, Jan 26, 2015 at 2:51 PM, Chad Rosier <mcrosier at codeaurora.org>

> +  /// \returns True if the intrinsic is a supported memory intrinsic.
> Info
> +  /// will contain additional information - whether the intrinsic may
> write
> +  /// or read to memory, volatility and the pointer.  Info is undefined
> +  /// if false is returned.
> +  virtual bool getTgtMemIntrinsic(IntrinsicInst *Inst,
> +                                  MemIntrinsicInfo &Info) const;

Please don't abbreviate this 'Tgt'. Just say "Target" if it is necessary.

Also, could you instead have a value of the enumerator which is == 0 be
returned? That will avoid a (fairly ugly) output parameter and make the
calling code still clean as you can just test for 'if (!foo)'.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150126/68072e52/attachment.html>

More information about the llvm-commits mailing list