[PATCH] Add per-test timeouts to lit

Daniel Dunbar daniel at zuster.org
Fri Jan 23 16:50:22 PST 2015


Hi Jonathan,

Thanks, this looks a lot better. I've noticed two more potential problems:

1. Watchdog.watch() has an unlikely race where the timer may have already
fired -- it should handle this case by just killing the new proc
immediately I would guess.

2. I tried your test test suite with execute_external=True, and it didn't
work for me. Does this work for you? I looked into it a little bit, and it
seems like the .communicate() method isn't returning in this case, even
though the subprocess does get killed. I haven't looked more than that...

 - Daniel


On Tue, Jan 20, 2015 at 2:04 PM, Jonathan Roelofs <jonathan at codesourcery.com
> wrote:

> ping
>
>
> http://reviews.llvm.org/D6584
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150123/2a9a949a/attachment.html>


More information about the llvm-commits mailing list