[PATCH] [lld] Fix the ELF shared library build targets

Rui Ueyama ruiu at google.com
Fri Jan 23 16:45:49 PST 2015


LGTM


REPOSITORY
  rL LLVM

================
Comment at: lib/Driver/GnuLdDriver.cpp:328
@@ +327,3 @@
+  else if ((p = elf::X86_64LinkingContext::create(triple)))  return p;
+  else return nullptr;
+}
----------------
This else-ifs can be early if-returns. s/else if/if/g

================
Comment at: lib/ReaderWriter/ELF/AArch64/AArch64LinkingContext.cpp:21
@@ +20,3 @@
+             new elf::AArch64LinkingContext(triple));
+
+  return nullptr;
----------------
Remove this line

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMLinkingContext.cpp:22
@@ +21,3 @@
+             new elf::ARMLinkingContext(triple));
+
+    return nullptr;
----------------
Remove this blank line

================
Comment at: lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.cpp:20
@@ +19,3 @@
+             new HexagonLinkingContext(triple));
+
+  return nullptr;
----------------
Ditto

================
Comment at: lib/ReaderWriter/ELF/Mips/MipsLinkingContext.cpp:24
@@ +23,3 @@
+             new MipsLinkingContext(triple));
+
+    return nullptr;
----------------
Ditto

================
Comment at: lib/ReaderWriter/ELF/PPC/PPCLinkingContext.cpp:23
@@ +22,3 @@
+             new elf::PPCLinkingContext(triple));
+
+  return nullptr;
----------------
Ditto

================
Comment at: lib/ReaderWriter/ELF/X86/X86LinkingContext.cpp:23
@@ +22,3 @@
+             new elf::X86LinkingContext(triple));
+
+  return nullptr;
----------------
Ditto

================
Comment at: lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.cpp:21
@@ +20,3 @@
+             new elf::X86_64LinkingContext(triple));
+
+  return nullptr;
----------------
Ditto

http://reviews.llvm.org/D7119

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list