[PATCH] non-Unicode response file support on Windows

Yunzhong Gao Yunzhong_Gao at playstation.sony.com
Fri Jan 23 15:55:09 PST 2015


Hi Rafael, Reid, David, thanks for the reviews. I separated the UTF-8 BOM part of the patch into http://reviews.llvm.org/D7156.
It sounds like the support for Shift-JIS encoded files may be specific only to Sony platforms, is that true? I am kinda curious to hear from someone developing in Japanese environment. In writing the original patch, I was making the assumption that if a text file on Windows does not start with the BOM sequence, then it is using the current codepage. That seems to be the case for files created from Notepad, but of course these files can be created from many different sources. If this assumption is not valid, then I wonder what would be a good way to differentiate a UTF-8 file from a current-codepage one; maybe a command-line option?
Thoughts and advice are appreciated,

- Gao


http://reviews.llvm.org/D7133

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list