[PATCH] Add llvm-pdbdump to tools

[Aaron Ballman]

On Fri, Jan 23, 2015 at 6:25 PM, Zachary Turner <zturner at google.com> wrote:
> By the way, I'm kind of mixed about the idea of supporting a full iterator interface (postfix ++, copying, etc).  The reason is that it requires cloning the COM interface.  It's possible, and the interface provides a method to do it, but it's probably a very slow operation, and generally not needed.  Also not needed for anything in the pdb dumper (at least in the foreseeable future).
>
> If you think it's better to do it anyway I can, but the main reason it's not there is just because Clone() is expensive and wasn't needed, so I decided not to add it.

I see what you mean about Clone() and possible expense. The downside
is, you're calling it an iterator, but it cannot be used like one (all
iterator categories are supposed to support prefix and postfix
increment).

I think it's probably acceptable for now to leave off the postfix
since you will get a compile error instead of bad behavior, but I
would at least add the other support stuff so they can be used more
generally by algorithms. Postfix usage would hopefully be a bit less
frequent than prefix usage anyway.

(Again, I am thinking of this as a general API since there's really no
reason this cannot be used by other things. For instance, I'm
wondering if LLDB might wind up wanting something like this for MSVC
debugger integration support someday.)

~Aaron

>
>
> http://reviews.llvm.org/D7153
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>