[lld] r226950 - [lld] Re-add REQUIRES line

[Filipe Cabecinhas]

The REQUIRES is acting on targets, not on hosts.
If the target is not configured in, we can't run llvm-objdump on the file.

For me, it's more like “the tests shouldn't rely on llvm-objdump”, but they
do. Until they're fixed, they will always fail if you didn't build that
backend, and they don't have the REQUIRES line.

In here, we're running llvm-config --targets-built and then adding them to
features: http://llvm.org/klaus/lld/blob/master/test/lit.cfg#L-141

Looking at that code, I see I have to add the X86 one and change the
REQUIRES to be lower case, I'll do that soon.
Thanks for pointing out, and let me know if you still have problems with it.

  Filipe


On Fri, Jan 23, 2015 at 2:58 PM, Rui Ueyama <ruiu at google.com> wrote:

> So you added back the REQUIRES line that was removed in r213390. Why?
>
> REQUIRES line should generally be avoided because all pasts should pass on
> all platforms. Is there any reason this test doesn't pass on non-MIPS
> machines?
>
> On Fri, Jan 23, 2015 at 2:32 PM, Filipe Cabecinhas <me at filcab.net> wrote:
>
>> Author: filcab
>> Date: Fri Jan 23 16:32:05 2015
>> New Revision: 226950
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=226950&view=rev
>> Log:
>> [lld] Re-add REQUIRES line
>>
>> Please don't remove REQUIRES lines when refreshing tests.
>>
>> Modified:
>>     lld/trunk/test/elf/Mips/base-address.test
>>
>> Modified: lld/trunk/test/elf/Mips/base-address.test
>> URL:
>> http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/Mips/base-address.test?rev=226950&r1=226949&r2=226950&view=diff
>>
>> ==============================================================================
>> --- lld/trunk/test/elf/Mips/base-address.test (original)
>> +++ lld/trunk/test/elf/Mips/base-address.test Fri Jan 23 16:32:05 2015
>> @@ -1,3 +1,5 @@
>> +# REQUIRES: Mips
>> +
>>  # Check executable base address configuration. Base address should be
>>  # equal to 0x400000 and the MIPS_BASE_ADDRESS dynamic tag's value should
>>  # be the same.
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150123/f3091ca9/attachment.html>