[llvm] r226958 - mips: Fix "XPASS" test results by removing 'not' commands

Reid Kleckner reid at kleckner.net
Fri Jan 23 14:55:31 PST 2015


Author: rnk
Date: Fri Jan 23 16:55:31 2015
New Revision: 226958

URL: http://llvm.org/viewvc/llvm-project?rev=226958&view=rev
Log:
mips: Fix "XPASS" test results by removing 'not' commands

These tests are asserting and crashing for me, and 'not' sees that as a
non-zero exit code instead of a signal code for obscure Windows reasons.
This causes the test to pass, giving me an unclean 'ninja check'.

The test is already XFAILd, so just run the test without 'not' and let
lit handle the failure.

Modified:
    llvm/trunk/test/MC/Disassembler/Mips/mips32r6/valid-xfail-mips32r6.txt
    llvm/trunk/test/MC/Disassembler/Mips/mips64r6/valid-xfail-mips64r6.txt

Modified: llvm/trunk/test/MC/Disassembler/Mips/mips32r6/valid-xfail-mips32r6.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/Disassembler/Mips/mips32r6/valid-xfail-mips32r6.txt?rev=226958&r1=226957&r2=226958&view=diff
==============================================================================
--- llvm/trunk/test/MC/Disassembler/Mips/mips32r6/valid-xfail-mips32r6.txt (original)
+++ llvm/trunk/test/MC/Disassembler/Mips/mips32r6/valid-xfail-mips32r6.txt Fri Jan 23 16:55:31 2015
@@ -1,7 +1,7 @@
 # Instructions that should be valid but currently fail for known reasons (e.g.
 # they aren't implemented yet).
 #
-# RUN: not llvm-mc %s -disassemble -triple=mips-unknown-linux -mcpu=mips32r6 | not FileCheck %s
+# RUN: llvm-mc %s -disassemble -triple=mips-unknown-linux -mcpu=mips32r6 | FileCheck %s
 # XFAIL: *
 0x20 0x40 0x00 0x01 # CHECK: bovc $0, $2, 4
 0x20 0x82 0x00 0x01 # CHECK: bovc $2, $4, 4

Modified: llvm/trunk/test/MC/Disassembler/Mips/mips64r6/valid-xfail-mips64r6.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/Disassembler/Mips/mips64r6/valid-xfail-mips64r6.txt?rev=226958&r1=226957&r2=226958&view=diff
==============================================================================
--- llvm/trunk/test/MC/Disassembler/Mips/mips64r6/valid-xfail-mips64r6.txt (original)
+++ llvm/trunk/test/MC/Disassembler/Mips/mips64r6/valid-xfail-mips64r6.txt Fri Jan 23 16:55:31 2015
@@ -1,7 +1,7 @@
 # Instructions that should be valid but currently fail for known reasons (e.g.
 # they aren't implemented yet).
 #
-# RUN: not llvm-mc %s -disassemble -triple=mips-unknown-linux -mcpu=mips64r6 | not FileCheck %s
+# RUN: llvm-mc %s -disassemble -triple=mips-unknown-linux -mcpu=mips64r6 | FileCheck %s
 # XFAIL: *
 0x20 0x40 0x00 0x01 # CHECK: bovc $0, $2, 4
 0x20 0x82 0x00 0x01 # CHECK: bovc $2, $4, 4





More information about the llvm-commits mailing list