[PATCH] Refactoring llvm command line parsing and option registration.

David Majnemer david.majnemer at gmail.com
Thu Jan 22 16:00:14 PST 2015


================
Comment at: lib/Support/CommandLine.cpp:1495
@@ -1505,5 +1494,3 @@
 
-    for (size_t i = CAOpt != nullptr, e = PositionalOpts.size(); i != e; ++i) {
-      if (PositionalOpts[i]->ArgStr[0])
-        outs() << " --" << PositionalOpts[i]->ArgStr;
-      outs() << " " << PositionalOpts[i]->HelpStr;
+    for (size_t i = 0, e = GlobalParser->PositionalOpts.size(); i != e; ++i) {
+      if (GlobalParser->PositionalOpts[i]->ArgStr[0])
----------------
Range-based for might be more concise.

================
Comment at: lib/Support/CommandLine.cpp:1516-1519
@@ -1526,5 +1515,6 @@
     // Print any extra help the user has declared.
-    for (std::vector<const char *>::iterator I = MoreHelp->begin(),
-                                             E = MoreHelp->end();
+    for (std::vector<const char *>::iterator I = GlobalParser->MoreHelp.begin(),
+                                             E = GlobalParser->MoreHelp.end();
          I != E; ++I)
       outs() << *I;
+    GlobalParser->MoreHelp.clear();
----------------
Range-based for might be more concise.

http://reviews.llvm.org/D7132

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list