[PATCH] [X86] Convert esp-relative movs of function arguments to pushes, step 2

[Chandler Carruth]

On Thu, Jan 22, 2015 at 12:57 PM, Reid Kleckner <rnk at google.com> wrote:

> lgtm
>
> I still think forming pushes prior to isel is the way to go long term.
> It's a lot easier to convert pushes to 'load, SP adjust, store' than it is
> to go the other way.
>

If that is the right way to go, then please don't add this complexity and
compile time hit. It doesn't make sense to add code, maintain that code,
fix bugs in it, and deal with the compile time when it wouldn't be needed
if we took the other approach.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150122/38ca0f85/attachment.html>