[PATCH] Add tail call optimization for thumb1-only targets rev. 3

Bjoern Haase bjoern.m.haase at web.de
Thu Jan 22 10:25:02 PST 2015


Hello Jon,

> This looks good, but I don't feel comfortable signing off on it. @t.p.northover, any thoughts on this?


Thank you for reviewing.

I agree. With a change like this, one should better be on the safe side and have more than one review.
I also would delay commiting until I have finished some regression tests on real-world hardware. This week, I'll not be finding the time to do it but I hopefully will do next week. As mentioned, I have test code that extensively uses continuation-style coding with many tail calls. 
Also as a second requirement for a commit, I will have to provide fixes for the 4 LIT regression tests that will trigger false failures because of the changed epilogue patterns. I will remove the superflous two lines within this change.


http://reviews.llvm.org/D7005

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list