[PATCH] [mips] Fix 'jumpy' debug line info around calls.

[David Blaikie]

On Thu, Jan 22, 2015 at 3:09 AM, Daniel Sanders <daniel.sanders at imgtec.com>
wrote:

> Test the .loc positioning more directly by matching the %call16 reloc.
>

Cool (I don't know anything about the MIPS asm/reloc syntax, etc, so I'll
take your word for that)

Maybe this could be simpler:

CHECK: .loc 1 3
CHECK-NOT: .loc
CHECK: %call16(f1)

CHECK: .loc 1 4
CHECK-NOT: .loc
CHECK: %call16(f1)

The extra nots/checks/suffixes don't seem important to the essence of this
test.

Anyway - I'm generally good with the test, but I'll leave it to someone
MIPS-y to sign off on the actual code change (unless you were only seeking
review of the test case part of things & you're confident in the code
change itself).

Thanks!
- David


>
>
> http://reviews.llvm.org/D7050
>
> Files:
>   lib/Target/Mips/Mips16ISelLowering.cpp
>   lib/Target/Mips/MipsISelLowering.cpp
>   lib/Target/Mips/MipsISelLowering.h
>   test/DebugInfo/Mips/fn-call-line.ll
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150122/755e218e/attachment.html>