[PATCH] [mips] Add new error message and improve testing for parsing the .module directive.

Daniel Sanders daniel.sanders at imgtec.com
Thu Jan 22 03:33:39 PST 2015


LGTM.

> I also fixed the other tests in mips-abi-bad.s, which all seemed to be broken.


Well spotted. They had whitespace before the colon.

Do the '# CHECK-NEXT: ^' lines work as expected? I believe FileCheck ignores most whitespace so we might only be checking that '^' appears somewhere on the line. If it turns out that that's the case I'm happy for stricter whitespace checking to be a follow-up patch.


http://reviews.llvm.org/D7095

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list