[PATCH] Allow the frontend to reserve x18 on AArch64

Andrew Turner andrew at fubar.geek.nz
Wed Jan 21 01:56:06 PST 2015


On Tue, 20 Jan 2015 10:13:18 -0800
Tim Northover <t.p.northover at gmail.com> wrote:

> Hi Andrew,
> 
> On 20 January 2015 at 09:59, Andrew Turner <andrew at fubar.geek.nz>
> wrote:
> > The attached patch allows the x18 platform register on AArch64 to be
> > reserved by users of llvm.
> 
> This looks reasonable, modulo one comment on the test:
> 
> +; CHECK-RESERVE-X18-NOT: ldr fp
> +; CHECK-RESERVE-X18-NOT: ldr x18
> +; CHECK-RESERVE-X18: Spill
> +; CHECK-RESERVE-X18-NOT: ldr fp
> +; CHECK-RESERVE-X18-NOT: ldr x18
> +; CHECK-RESERVE-X18: ret
> 
> These are identical to the DARWIN checks, aren't they? If so, they
> should probably be combined (likely by renaming to CHECK-RESERVE-X18
> for both platforms).

The attached updated patch merges these checks to both use
CHECK-RESERVE-X18. If you're happy with it can someone commit it for me?

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm_fixed_x18.diff
Type: text/x-patch
Size: 2945 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150121/90d9f488/attachment.bin>


More information about the llvm-commits mailing list