[PATCH] [lld] Boot bitrotting add_lld_library() from CMake build

Chandler Carruth chandlerc at gmail.com
Tue Jan 20 15:18:27 PST 2015


Interesting...

So, two high-level comments:

1. If you're seriously looking at fixing the layering and build of LLD, please go reply to my email thread about cleaning up its layering. We need some agreed upon target library factoring / layering before trying to move LLD in any direction. I think at least Rui and Nick need to agree on that plan...

2. This is highlighting a problem with add_llvm_library that I should have spotted before asking you to use it. Sorry for that. Namely, I don't think it makes sense to have 'LLVMlldConfig' as a library name, and that'll be the result of this approach as far as I understand it.

To address #2 I think we may need to excise some of add_llvm_library'ess logic to make it re-usable, and allow it to override the project name. Or we'll need it to pick up the project prefix from a variable maybe? That might be cleaner. Anyways, we should make it so that these libraries are LLDFoo to compliment the LLVMFoo naming.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7074

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list