[llvm] r226541 - IR: Move MDNode clone() methods from ValueMapper to MDNode, NFC

[Duncan Exon Smith]

I'll look into it, but I don't have an MSVC box so any help would be appreciated.  (Note that I suspect this isn't the commit to blame.  If you were able to do a bisect that would help a lot.)

-- dpnes

> On Jan 20, 2015, at 1:19 AM, İsmail Dönmez <ismail at donmez.ws> wrote:
> 
> Hi,
> 
>> On Tue, Jan 20, 2015 at 4:56 AM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>> Author: dexonsmith
>> Date: Mon Jan 19 20:56:57 2015
>> New Revision: 226541
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=226541&view=rev
>> Log:
>> IR: Move MDNode clone() methods from ValueMapper to MDNode, NFC
>> 
>> Now that the clone methods used by `MapMetadata()` don't do any
>> remapping (and return a temporary), they make more sense as member
>> functions on `MDNode` (and subclasses).
> 
> This seems to break MSVC (2013) builds for me
> 
> FAIL: LLVM-Unit :: IR/IRTests.exe/MDLocationTest.getTemporary (19749 of 20220)
> ******************** TEST 'LLVM-Unit :: IR/IRTests.exe/MDLocationTest.getTemporary' FAILED ********************
> Note: Google Test filter = MDLocationTest.getTemporary
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from MDLocationTest
> [ RUN      ] MDLocationTest.getTemporary
> ..\unittests\IR\MetadataTest.cpp(560): error: Value of: L->isTemporary()
>   Actual: false
> Expected: true
> [  FAILED  ] MDLocationTest.getTemporary (47 ms)
> [----------] 1 test from MDLocationTest (47 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (47 ms total)
> [  PASSED  ] 0 tests.
> [  FAILED  ] 1 test, listed below:
> [  FAILED  ] MDLocationTest.getTemporary
> 
>  1 FAILED TEST
> 
> ********************
> FAIL: LLVM-Unit :: IR/IRTests.exe/MDNodeTest.isTemporary (19760 of 20220)
> ******************** TEST 'LLVM-Unit :: IR/IRTests.exe/MDNodeTest.isTemporary' FAILED ********************
> Note: Google Test filter = MDNodeTest.isTemporary
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from MDNodeTest
> [ RUN      ] MDNodeTest.isTemporary
> ..\unittests\IR\MetadataTest.cpp(332): error: Value of: T->isTemporary()
>   Actual: false
> Expected: true
> [  FAILED  ] MDNodeTest.isTemporary (0 ms)
> [----------] 1 test from MDNodeTest (0 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (0 ms total)
> [  PASSED  ] 0 tests.
> [  FAILED  ] 1 test, listed below:
> [  FAILED  ] MDNodeTest.isTemporary
> 
>  1 FAILED TEST
> 
> ********************
> FAIL: LLVM-Unit :: IR/IRTests.exe/MDNodeTest.replaceWithDistinct (19763 of 20220)
> ******************** TEST 'LLVM-Unit :: IR/IRTests.exe/MDNodeTest.replaceWithDistinct' FAILED ********************
> Note: Google Test filter = MDNodeTest.replaceWithDistinct
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from MDNodeTest
> [ RUN      ] MDNodeTest.replaceWithDistinct
> ..\unittests\IR\MetadataTest.cpp(493): error: Value of: Temp->isTemporary()
>   Actual: false
> Expected: true
> ..\unittests\IR\MetadataTest.cpp(506): error: Value of: Temp->isTemporary()
>   Actual: false
> Expected: true
> [  FAILED  ] MDNodeTest.replaceWithDistinct (0 ms)
> [----------] 1 test from MDNodeTest (0 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (0 ms total)
> [  PASSED  ] 0 tests.
> [  FAILED  ] 1 test, listed below:
> [  FAILED  ] MDNodeTest.replaceWithDistinct
> 
>  1 FAILED TEST
> 
> ********************
> FAIL: LLVM-Unit :: IR/IRTests.exe/MDNodeTest.replaceWithUniqued (19764 of 20220)
> ******************** TEST 'LLVM-Unit :: IR/IRTests.exe/MDNodeTest.replaceWithUniqued' FAILED ********************
> Note: Google Test filter = MDNodeTest.replaceWithUniqued
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from MDNodeTest
> [ RUN      ] MDNodeTest.replaceWithUniqued
> ..\unittests\IR\MetadataTest.cpp(447): error: Value of: Temp->isTemporary()
>   Actual: false
> Expected: true
> ..\unittests\IR\MetadataTest.cpp(459): error: Value of: Temp->isTemporary()
>   Actual: false
> Expected: true
> ..\unittests\IR\MetadataTest.cpp(471): error: Value of: Temp->isTemporary()
>   Actual: false
> Expected: true
> [  FAILED  ] MDNodeTest.replaceWithUniqued (0 ms)
> [----------] 1 test from MDNodeTest (0 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (0 ms total)
> [  PASSED  ] 0 tests.
> [  FAILED  ] 1 test, listed below:
> [  FAILED  ] MDNodeTest.replaceWithUniqued
> 
>  1 FAILED TEST
> 
> ********************
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150120/f272b4d8/attachment.html>