[llvm] r226415 - Attempt to fix the MSVC build by working around a layering issue

Chandler Carruth chandlerc at google.com
Sun Jan 18 16:53:23 PST 2015


MSVC still seems hosed. Here is a build that claims to have this commit as
well:

http://lab.llvm.org:8011/builders/lldb-x86-win7-msvc/builds/76/

On Sun, Jan 18, 2015 at 12:43 PM, David Blaikie <dblaikie at gmail.com> wrote:

> Author: dblaikie
> Date: Sun Jan 18 14:43:57 2015
> New Revision: 226415
>
> URL: http://llvm.org/viewvc/llvm-project?rev=226415&view=rev
> Log:
> Attempt to fix the MSVC build by working around a layering issue
>
> Since MCStreamer isn't part of Support, the dtor can't be called from
> here - so just pass by reference instead. This is rather imperfect, but
> will hopefully suffice.
>
> Modified:
>     llvm/trunk/include/llvm/Support/TargetRegistry.h
>
> Modified: llvm/trunk/include/llvm/Support/TargetRegistry.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/TargetRegistry.h?rev=226415&r1=226414&r2=226415&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/Support/TargetRegistry.h (original)
> +++ llvm/trunk/include/llvm/Support/TargetRegistry.h Sun Jan 18 14:43:57
> 2015
> @@ -381,7 +381,7 @@ namespace llvm {
>      /// createAsmPrinter - Create a target specific assembly printer
> pass.  This
>      /// takes ownership of the MCStreamer object.
>      AsmPrinter *createAsmPrinter(TargetMachine &TM,
> -                                 std::unique_ptr<MCStreamer> Streamer)
> const {
> +                                 std::unique_ptr<MCStreamer> &&Streamer)
> const {
>        if (!AsmPrinterCtorFn)
>          return nullptr;
>        return AsmPrinterCtorFn(TM, std::move(Streamer));
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150118/357c1af2/attachment.html>


More information about the llvm-commits mailing list