[PATCH] [Sanitizers] Intercept opendir()

Viktor Kutuzov vkutuzov at accesssoftek.com
Fri Jan 16 06:32:55 PST 2015


> If opendir() calls strlen(), which we already intersept, won't we see the access w/o this interceptor?


The point is that FreeBSD's opendir() calls strlen() for inspecting related internal structures and not the file path passed (the comment should mention it; my mistake). Then given we don't intercept opendir(), we indeed do catch poisoned file paths, but we also generate false positives on these internal structures. Since COMMON_INTERCEPTOR_ENTER() includes the declaration for interceptor scope, it suppresses the checks for whatever the real opendir() relies on.


http://reviews.llvm.org/D6968

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list