[llvm] r226242 - Revert "Revert Don't create new comdats in CodeGen"

[Rafael Espíndola]

And to answer my own question, the failing target is

 projects\compiler-rt\lib\asan\tests\Asan-i386-inline-Test


On 16 January 2015 at 08:22, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
> if (SANITIZER_COMMON_SUPPORTED_ARCH AND NOT LLVM_USE_SANITIZER AND
>     (OS_NAME MATCHES "Android|Darwin|Linux|FreeBSD" OR
>     (OS_NAME MATCHES "Windows" AND MSVC AND CMAKE_SIZEOF_VOID_P EQUAL 4)))
>
> Looks like you forgot to mention that one must use 32 bits.
>
>
> On 16 January 2015 at 08:17, Rafael Espíndola
> <rafael.espindola at gmail.com> wrote:
>> COMPILER_RT_HAS_ASAN is not being set.
>>
>> It really seems this is effectively an out of tree user. Please put
>> some effort in helping reproduce the failure. At the very least tell
>> me which target it is trying to link. Better yet, send the
>> preprocessed source and command line used to build
>>
>> ASAN_NOINST_TEST_OBJECTS.asan_fake_stack_test.cc.i386-inline.o
>>
>> and
>>
>> ASAN_NOINST_TEST_OBJECTS.gtest-all.cc.i386-inline.o
>>
>>
>> On 16 January 2015 at 08:07, Rafael Espíndola
>> <rafael.espindola at gmail.com> wrote:
>>> I obviously do, and it is being read. Touching
>>> compiler-rt/CMakeLists.txt causes cmake to run again, but no
>>> check-asan.
>>>
>>> Again, what target is it trying to link?
>>>
>>> On 16 January 2015 at 08:03, Timur Iskhodzhanov <timurrrr at google.com> wrote:
>>>> Do you have projects/compiler-rt in your checkout?
>>>>
>>>>
>>>> On Fri Jan 16 2015 at 4:03:11 PM Rafael Espíndola
>>>> <rafael.espindola at gmail.com> wrote:
>>>>>
>>>>> On 16 January 2015 at 08:01, Timur Iskhodzhanov <timurrrr at google.com>
>>>>> wrote:
>>>>> > The host compiler is MSVC2013, the Windows bot is not public
>>>>> > unfortunately
>>>>> > due to hardware availability reasons.
>>>>> >
>>>>> > The target is one of the projects/compiler-rt tests built as part of
>>>>> > check-asan
>>>>>
>>>>> Can you tell me which file it is trying to link?
>>>>>
>>>>> Cheers,
>>>>> Rafael