[PATCH] [ELF] Add --{,no-}as-needed.

Rui Ueyama ruiu at google.com
Thu Jan 15 15:57:41 PST 2015

Comment at: lib/ReaderWriter/ELF/OutputELFWriter.h:211
@@ -192,1 +210,3 @@
+      _soNeeded.insert(soname);
+  }
   // Never mark the dynamic linker as DT_NEEDED
shankarke wrote:
> It looks like all the needed entries will not be in link order. The loop(just above your change) goes over the list of files that are really needed and add its to the needed list.
That's true but that's not a new issue. llvm::StringSet doesn't preserve order, so even before this patch the order of DT_NEEDED entries were random. Let me address that issue in a separate patch.



More information about the llvm-commits mailing list