[PATCH] Fix Reassociate handling of constant in presence of undef float

Mehdi AMINI mehdi.amini at apple.com
Thu Jan 15 09:53:52 PST 2015


REPOSITORY
  rL LLVM

================
Comment at: test/Transforms/Reassociate/undef.ll:4
@@ +3,3 @@
+; Reassociate pass use to crash on these example
+
+
----------------
spatel wrote:
> Please use FileCheck for the expected output rather than just assuming a lack of crash is correct.
> 
> Nit: "The Reassociate pass used to crash on these examples."
Why should I add a Filecheck for a crash? I looked at what was done by other crash test in the test suite.
What should I check exactly?

Thanks!

http://reviews.llvm.org/D6993

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list