[llvm] r226038 - Don't create new comdats in CodeGen.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Jan 15 07:54:10 PST 2015

On 15 January 2015 at 10:45, Timur Iskhodzhanov <timurrrr at google.com> wrote:
> Hi Rafael,
> This change has completely broken down AddressSanitizer on Windows (ninja
> check-asan), it fails to link anything due to multiple defined vftables,
> e.g.
> libcpmt.lib(xdateord.obj) : error LNK2005: "const
> std::_System_error_category::`vftable'"
> (??_7_System_error_category at std@@6B@) already defined in
> sanitizer_allocator_test.cc.i386.o
> I'm going to revert your change.
> Please coordinate with David and Kostya if you have any questions on how
> COMDATs interplay with AddressSanitizer.

Looks like it caused other comdat problems on windows. I am currently
trying a bootstrap on mingw to debug it.

Do revert it please, I didn't realized it was that bad.


More information about the llvm-commits mailing list