[llvm] r225953 - SelectionDAG: add a -filter-view-dags option to llc

Daniel Sanders Daniel.Sanders at imgtec.com
Thu Jan 15 07:47:38 PST 2015


Thanks

> -----Original Message-----
> From: Mehdi Amini [mailto:mehdi.amini at apple.com]
> Sent: 15 January 2015 12:05
> To: Daniel Sanders
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm] r225953 - SelectionDAG: add a -filter-view-dags option to
> llc
> 
> Fixed in r226163.
> 
> Sorry about that.
> 
> Mehdi
> 
> > On Jan 15, 2015, at 3:58 AM, Daniel Sanders <Daniel.Sanders at imgtec.com>
> wrote:
> >
> >>
> ==========================================================
> >> ====================
> >> --- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp (original)
> >> +++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp Wed
> Jan
> >> 14 00:03:18 2015
> >> @@ -652,6 +656,12 @@ void SelectionDAGISel::CodeGenAndEmitDAG
> >>   std::string BlockName;
> >>   int BlockNumber = -1;
> >>   (void)BlockNumber;
> >> +  bool MatchFilterBB = false; (void)MatchFilterBB;
> >> +#ifndef NDEBUG
> >> +  MatchFilterBB = (!FilterDAGBasicBlockName.empty() &&
> >> +                   FilterDAGBasicBlockName ==
> >> +                       FuncInfo->MBB->getBasicBlock()->getName().str());
> >> +#endif
> >> #ifdef NDEBUG
> >>   if (ViewDAGCombine1 || ViewLegalizeTypesDAGs || ViewLegalizeDAGs
> ||
> >>       ViewDAGCombine2 || ViewDAGCombineLT || ViewISelDAGs ||
> >> ViewSchedDAGs ||
> >
> > Shouldn't the MatchFilterBB line be:
> > 	MatchFilterBB = (FilterDAGBasicBlockName.empty() ||
> FilterDAGBasicBlockName == FuncInfo->MBB->getBasicBlock()-
> >getName().str());
> > At the moment, using -view-legalize-types-dags by itself does nothing.





More information about the llvm-commits mailing list