[PATCH] [TSan][MIPS] Adding support for MIPS64

Sagar Thakur Sagar.Thakur at imgtec.com
Thu Jan 15 05:19:07 PST 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/tsan/tests/CMakeLists.txt:38
@@ +37,3 @@
+  if(UNIX AND NOT APPLE)
+    foreach(arch ${TSAN_SUPPORTED_ARCH})
+      parse_arguments(TEST "SOURCES;HEADERS" "" ${ARGN})
----------------
Hi @samsonov

On X86_64, with the previous patch, standalone compilation was failing with -DCOMPILER_RT_INCLUDE_TESTS=ON because of a cmake error. This was happening because the funtion get_target_flags_for_arch () in add_tsan_unittest macro was revieving incorrect arch value in its first argument.
I have added this change to enable unit tests for all architectures in this patch.

Does this change look good ?

http://reviews.llvm.org/D6291

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list