[PATCH] AArch64: Relax assert about large shift sizes.

[Quentin Colombet]

Good, thanks for checking.

Cheers,
-Quentin

On Jan 14, 2015, at 11:18 AM, Matthias Braun <matze at braunis.de> wrote:

> I just tried fast-isel and it fails on the shift and falls back to normal selection DAG, it doesn't appear to hit the places with the asserts in the aarch64 backend.
> 
>> On Jan 13, 2015, at 5:35 PM, Quentin Colombet <qcolombet at apple.com> wrote:
>> 
>> Hi Matthias,
>> 
>> On Jan 12, 2015, at 7:06 PM, Matthias Braun <matze at braunis.de> wrote:
>> 
>>> Abandoning in favor of http://reviews.llvm.org/D6946
>> 
>> I saw that in the new approach you’re fixing the DAG combiner, which is good, but I have one question. Did you try your test case with fast-isel?
>> I am wondering if we might hit the same assert through that path.
>> 
>> Thanks,
>> -Quentin
>> 
>>> 
>>> 
>>> http://reviews.llvm.org/D6940
>>> 
>>> EMAIL PREFERENCES
>>> http://reviews.llvm.org/settings/panel/emailpreferences/
>>> 
>>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>