[llvm] r225941 - X86: validate 'int' instruction

Joerg Sonnenberger joerg at britannica.bec.de
Tue Jan 13 23:58:33 PST 2015


On Wed, Jan 14, 2015 at 05:10:21AM -0000, Saleem Abdulrasool wrote:
> Author: compnerd
> Date: Tue Jan 13 23:10:21 2015
> New Revision: 225941
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=225941&view=rev
> Log:
> X86: validate 'int' instruction
> 
> The int instruction takes as an operand an 8-bit immediate value.  Validate that
> the input is valid rather than silently truncating the value.

I think this is the wrong approach. We don't want to handle every case
of i8imm specially, but should check the immediates in one place. The
problem occurs with pretty much any instruction that has immediates.

Joerg



More information about the llvm-commits mailing list