[patch][pr19848] Don't create new comdats in CodeGen

Duncan P. N. Exon Smith dexonsmith at apple.com
Tue Jan 13 14:47:08 PST 2015

> On 2015-Jan-13, at 14:35, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> On 12 January 2015 at 21:25, Rafael EspĂ­ndola
> <rafael.espindola at gmail.com> wrote:
>>> OK, that makes sense.  It would be nice to assert that no GlobalObjects that
>>> should've had their Comdat filled in were missed.
>> Any idea on how to do it? I can only think of walking all of ValueList
>> at the end of ParseValueSymbolTable. Would that be worth it?
> If you think it is, the attached patch does it.

Should the `for` loop be wrapped in an `#ifndef NDEBUG`?

> Let me know which one you prefer.

(I'll leave this up to David.)

> Cheers,
> Rafael
> <t.patch>

More information about the llvm-commits mailing list