[PATCH] CodeGen support for x86_64 SEH catch handlers in LLVM

David Majnemer david.majnemer at gmail.com
Tue Jan 13 14:25:06 PST 2015

LGTM if you add a predicate which breaks down what values of TypeID correspond to what SEH action.

We should also rename `@llvm.eh.typeid.for` to something less Itanium specific to enhance clarity, though such a change shouldn't block this code.

Comment at: lib/CodeGen/AsmPrinter/Win64Exception.cpp:230-231
@@ +229,4 @@
+      MCSymbol *ClauseLabel = LPad->ClauseLabels[I];
+      assert(TypeID >= 0 && "SEH personality functions don't support filter "
+                            "clauses in landing pads");
rnk wrote:
> majnemer wrote:
> > Is this an IR invariant?
> No. What should we do with these? We can't really implement filters with the SEH personality function.
As discussed offline, such entries should be skipped.



More information about the llvm-commits mailing list