[PATCH] [ARM] Correct POP reglist handling

Saleem Abdulrasool compnerd at compnerd.org
Mon Jan 12 18:55:04 PST 2015


Thanks for addressing all the review comments.


================
Comment at: ../llvm/test/MC/ARM/thumb-load-store-multiple.s:13
@@ -8,3 +12,3 @@
 	.type ldm,%function
-ldb:
+ldm:
 	ldm r0!, {r1, sp}
----------------
oops.

================
Comment at: ../llvm/test/MC/ARM/thumb-load-store-multiple.s:34
@@ -29,3 +33,3 @@
 @ CHECK: error: SP may not be in the register list
-	ldm r0!, {lr, pc}
+	ldmdb r0!, {lr, pc}
 @ error: PC and LR may not be in the register list simultaneously
----------------
Ugh.  Thanks for fixing this.

http://reviews.llvm.org/D6819

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list