[PATCH] Convert other drivers to use WrapperNode.

Rui Ueyama ruiu at google.com
Mon Jan 12 17:06:03 PST 2015

It's not intentional and I believe it's not actually parsed immediately.
Can you elaborate a bit why you think files would be parsed not in parallel?

As to the name, I totally agree with that. parseFile is no longer a good
name for that function. I'll rename loadFile (or readFile, but read could
imply that we are going to parse it as part of reading, so I'm inclined to

On Mon, Jan 12, 2015 at 5:02 PM, kledzik at apple.com <kledzik at apple.com>

> It still looks like mach-o files are parsed immediately (not in
> parallel).  If that is intentional, because reworking the mach-o logic is
> complicated, then leave a FIXME comment there.
> It would be helpful to rename parseFile() if its goal is no longer to
> parse files.  I seems like its goal is to load the file into memory, and
> later parse()/doParse() are supposed to do the actual parsing.
> http://reviews.llvm.org/D6874
>   http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150112/a1b452d4/attachment.html>

More information about the llvm-commits mailing list