[patch][pr19848] Don't create new comdats in CodeGen
david.majnemer at gmail.com
Mon Jan 12 15:56:16 PST 2015
On Mon, Jan 12, 2015 at 2:28 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:
> On 12 January 2015 at 16:32, David Majnemer <david.majnemer at gmail.com>
> > Why do you create the explicit comdat group in ParseValueSymbolTable
> > of when you detect the implicit comdat in ParseModule?
> The name is hasn't been read yet in ParseModule, so it is not possible
> to create the final comdat.
OK, that makes sense. It would be nice to assert that no GlobalObjects
that should've had their Comdat filled in were missed.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits