[PATCHES] R600/SI: VI fixes
Matthew.Arsenault at amd.com
Mon Jan 12 13:50:15 PST 2015
On 12/14/2014 01:50 PM, Marek Olšák wrote:
> What should #3 test? I'm not sure how to test the bug that it fixes.
> It was a bug in encoding, that's something llvm-lit isn't capable of
So in generally for encoding, you can use -show-mc-encoding although
it's kind of hard for this output. I would think in this specific case
testing the _e32 / _e64 in the output would work. I think it would be
enough to just run the existing tests for these instructions with a VI
> On Fri, Dec 12, 2014 at 11:57 PM, Matt Arsenault <arsenm2 at gmail.com> wrote:
>>> On Dec 12, 2014, at 4:41 PM, Marek Olšák <maraeo at gmail.com> wrote:
>>> Please review.
>> #1 - Why can’t this use the same encoding mapping trick the other instructions do so everything except encoding doesn’t need to see separate opcodes?
>> #2 LGTM
>> #3 LGTM but needs a test
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
More information about the llvm-commits