[PATCH] GVN: propagate fcmp equalities (PR17713)

Pete Cooper peter_cooper at apple.com
Mon Jan 12 10:02:55 PST 2015


================
Comment at: lib/Transforms/Scalar/GVN.cpp:2188
@@ -2183,2 +2187,3 @@
+
       // If "A >= B" is known true, replace "A < B" with false everywhere.
       CmpInst::Predicate NotPred = Cmp->getInversePredicate();
----------------
I think you need a test case which verifies (positive and negative) cases of a floating point compare here.  Looks like a ugt can prove an ole is false for example.

The rest of the changes LGTM if you add tests for these.

http://reviews.llvm.org/D6911

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list