[PATCH] [Mips][ABI]The ELF container needs to depend on the ABI rather than the target triple.

Vladimir Medic Vladimir.Medic at imgtec.com
Mon Jan 12 06:30:41 PST 2015

Comment at: lib/Target/Mips/MCTargetDesc/MipsABIInfo.cpp:50-55
@@ +49,8 @@
+cl::opt<std::string> TargetABI(
+  "target-abi",
+  cl::init(""),
+  cl::desc("ABI used"),
+  cl::Hidden);
+MipsABIInfo::MipsABIInfo(bool is64Bit) {
dsanders wrote:
> You'll need to resolve a conflict with the 'target-abi' option Eric Christopher added in r224492. It's normally accessed through the TargetOptions class.
> I tried a couple quick fixes but didn't successfully get 'make check' passing.
It seems to me that the patch does the same thing we do, only it puts the flag info TargetOptions and accesses trough TargetMachine class, while we are putting it into MipsABIInfo class. I'll try to see if we can use their implementation in our code.



More information about the llvm-commits mailing list