[PATCH] Fix undefined behavior (shift of negative value) in RuntimeDyldMachOAArch64::encodeAddend.

Chandler Carruth chandlerc at google.com
Fri Jan 9 15:52:53 PST 2015


(Adding Artem so he sees this)

On Fri, Jan 9, 2015 at 3:48 PM, Alexey Samsonov <vonosmas at gmail.com> wrote:

> Just noticed that a similar fix is already mailed in
> http://reviews.llvm.org/D6884
>

Thanks to both for jumping on this. I prefer casting to masking off the
bits -- it is more self documenting that we lose the 17 high bits.
Otherwise LGTM.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150109/dc93ec58/attachment.html>


More information about the llvm-commits mailing list