[PATCH] [lld] Don't fail if parent directory contains a '+' character

Greg Fitzgerald garious at gmail.com
Fri Jan 9 11:26:33 PST 2015


Hi shankar.easwaran,

The test matches the absolute path of a file.  If that path contains a '+' character, the test will fail.  This patch adds '+' to the list of valid path characters.

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D6902

Files:
  test/elf/dynamic-undef.test
  test/elf/filenotfound.test

Index: test/elf/dynamic-undef.test
===================================================================
--- test/elf/dynamic-undef.test
+++ test/elf/dynamic-undef.test
@@ -26,9 +26,9 @@
 RUN: --use-shlib-undefines --no-allow-shlib-undefined  2> %t2
 RUN: llvm-readobj -symbols %t.useundefines | FileCheck -check-prefix=SHLIB-UNDEF-SYMBOLS %s
 
-EXEC: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts
-SHLIB: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts
-EXEC-NOT: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: weakfoo
-SHLIB-NOT: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: weakfoo
+EXEC: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts
+SHLIB: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts
+EXEC-NOT: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: weakfoo
+SHLIB-NOT: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: weakfoo
 SHLIB-NOUNDEF-NOT: Name: puts
 SHLIB-UNDEF-SYMBOLS: Name: puts
Index: test/elf/filenotfound.test
===================================================================
--- test/elf/filenotfound.test
+++ test/elf/filenotfound.test
@@ -1,3 +1,3 @@
 # Check that a file that cannot be found results in a proper error message
 RUN: not lld -flavor gnu -target x86_64 %p/Inputs/nofile.o 2>&1 | FileCheck %s
-#CHECK: lld: cannot find file {{[-_A-Za-z0-9.\\/:]+}}nofile.o
+#CHECK: lld: cannot find file {{[+-_A-Za-z0-9.\\/:]+}}nofile.o

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6902.17938.patch
Type: text/x-patch
Size: 1474 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150109/1486ca2a/attachment.bin>


More information about the llvm-commits mailing list