[PATCH] [mips] Add support for accessing $gp as a named register.

Daniel Sanders Daniel.Sanders at imgtec.com
Fri Jan 9 09:24:13 PST 2015


Thanks.

> Missed `override` keyword?

Oops. Fixed in the commit (r225529).

> -----Original Message-----
> From: Simon Atanasyan [mailto:simon at atanasyan.com]
> Sent: 09 January 2015 15:57
> To: Daniel Sanders; Sasa Stankovic; Vladimir Medic; simon at atanasyan.com
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [PATCH] [mips] Add support for accessing $gp as a named register.
> 
> LGTM (with a nit).
> 
> 
> ================
> Comment at: lib/Target/Mips/MipsISelLowering.h:265
> @@ -264,1 +264,3 @@
> 
> +    unsigned getRegisterByName(const char* RegName, EVT VT) const;
> +
> ----------------
> Missed `override` keyword?
> 
> http://reviews.llvm.org/D6893
> 
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
> 





More information about the llvm-commits mailing list