[PATCH] [ARM] Correct POP reglist handling

Jonathan Roelofs jonathan at codesourcery.com
Fri Jan 9 08:41:28 PST 2015


REPOSITORY
  rL LLVM

================
Comment at: ../llvm/test/MC/ARM/thumb-load-store-multiple.s:4
@@ -3,1 +3,3 @@
+@ RUN: not llvm-mc -triple thumbv7m-eabi -filetype asm -o - %s 2>&1 \
+@ RUN:     | FileCheck --check-prefix=CHECK-V7M %s
 
----------------
Instead of duplicating all of the shared cases below, how about:

@ RUN: not llvm-mc -triple thumbv7a-eabi -filetype asm -o - %s 2>&1 \
@ RUN:     | FileCheck --check-prefix=CHECK --check-prefix=CHECK-V7A %s
@ RUN: not llvm-mc -triple thumbv7m-eabi -filetype asm -o - %s 2>&1 \
@ RUN:     | FileCheck --check-prefix=CHECK --check-prefix=CHECK-V7M %s

Then only split out the cases that are different. I think that will significantly reduce the diff in this file.

http://reviews.llvm.org/D6819

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list