[PATCH] [LLVMdev] More FMA folding opportunities

[Olivier Sallenave]

Sorry about that guys. Thanks Hal for the (very) quick fix!

Olivier

2015-01-08 20:31 GMT-05:00 Hal Finkel <hfinkel at anl.gov>:

> ----- Original Message -----
> > From: "Hal Finkel" <hfinkel at anl.gov>
> > To: "Owen Anderson" <resistor at mac.com>
> > Cc: "Olivier H Sallenave" <ohsallen at us.ibm.com>,
> llvm-commits at cs.uiuc.edu
> > Sent: Thursday, January 8, 2015 6:48:34 PM
> > Subject: Re: [PATCH] [LLVMdev] More FMA folding opportunities
> >
> > ----- Original Message -----
> > > From: "Hal Finkel" <hfinkel at anl.gov>
> > > To: "Owen Anderson" <resistor at mac.com>
> > > Cc: "Olivier H Sallenave" <ohsallen at us.ibm.com>,
> > > llvm-commits at cs.uiuc.edu
> > > Sent: Thursday, January 8, 2015 6:19:14 PM
> > > Subject: Re: [PATCH] [LLVMdev] More FMA folding opportunities
> > >
> > > ----- Original Message -----
> > > > From: "Owen Anderson" <resistor at mac.com>
> > > > To: "Hal Finkel" <hfinkel at anl.gov>
> > > > Cc: "Olivier H Sallenave" <ohsallen at us.ibm.com>,
> > > > llvm-commits at cs.uiuc.edu
> > > > Sent: Thursday, January 8, 2015 6:16:57 PM
> > > > Subject: Re: [PATCH] [LLVMdev] More FMA folding opportunities
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > On Jan 8, 2015, at 6:06 PM, Hal Finkel < hfinkel at anl.gov > wrote:
> > > >
> > > > Olivier, Aditya is right. You need to add the FP_EXTEND to the
> > > > operands of the resulting FMA as appropriate. Can you please fix
> > > > that? We can also move those under the "aggressive" flag for now.
> > > >
> > > >
> > > > Can you fix or revert this ASAP, please? The missing extends are
> > > > breaking our branches pretty badly.
> > >
> > > Yep, will do in a few minutes.
> >
> > I moved the transformations behind the aggressive flag in r225485 --
> > that should unbreak your builds while I fix the extends.
>
> FP_EXTEND nodes added as of r225492. Thanks for pointing this out!
>
>  -Hal
>
> >
> >  -Hal
> >
> > >
> > >  -Hal
> > >
> > > >
> > > >
> > > > —Owen
> > >
> > > --
> > > Hal Finkel
> > > Assistant Computational Scientist
> > > Leadership Computing Facility
> > > Argonne National Laboratory
> > >
> > > _______________________________________________
> > > llvm-commits mailing list
> > > llvm-commits at cs.uiuc.edu
> > > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> > >
> >
> > --
> > Hal Finkel
> > Assistant Computational Scientist
> > Leadership Computing Facility
> > Argonne National Laboratory
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
>
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150109/8258a127/attachment.html>