[PATCH] [SelectionDAG] Allow targets to specify legality of extloads' result type (in addition to the memory type)

Ahmed Bougacha ahmed.bougacha at gmail.com
Wed Jan 7 15:07:47 PST 2015


FYI: while changing other targets, I decided to flip the order of
MemVT and ValVT in [gs]etLoadExtAction. In this patch, we had:

    setLoadExtAction(.., MVT ValVT, MVT MemVT, ..)
    setTruncStoreAction(MVT ValVT, MVT MemVT, ..)

I think it's more useful to keep "source" and "destination" types
consistent, that is:

    setLoadExtAction(.., MVT MemVT, MVT ValVT, ..)
    setTruncStoreAction(MVT ValVT, MVT MemVT, ..)

This avoids having consecutive calls to both, with the same arguments,
but different ordering.
I'll also rename them to SrcVT/DestVT to make that clear.

Anyway, thanks for the reviews,

-Ahmed


On Mon, Dec 8, 2014 at 6:03 AM, hfinkel at anl.gov <hfinkel at anl.gov> wrote:
> This also looks good to me -- this is the right thing to do -- as you've mentioned, you need to update the other in-tree targets before this lands.
>
> http://reviews.llvm.org/D6532
>
>



More information about the llvm-commits mailing list