[llvm] r225386 - Fix uninitialized memory read in llvm-dsymutil for the second time.

Frédéric Riss friss at apple.com
Wed Jan 7 13:21:24 PST 2015


> On Jan 7, 2015, at 1:13 PM, Alexey Samsonov <vonosmas at gmail.com> wrote:
> 
> Author: samsonov
> Date: Wed Jan  7 15:13:30 2015
> New Revision: 225386
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=225386&view=rev
> Log:
> Fix uninitialized memory read in llvm-dsymutil for the second time.
> 
> This was already fixed by r224481, but apparently was accidentally
> reverted in r225207.

Thanks and sorry about that, I must have messed up the merge when rebasing (although I don’t remember having to merge at all...). I suppose this got caught by the ASAN bots, don’t they send mail notifications, because I didn’t get anything?

Fred

> Modified:
>    llvm/trunk/tools/dsymutil/MachODebugMapParser.cpp
> 
> Modified: llvm/trunk/tools/dsymutil/MachODebugMapParser.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/dsymutil/MachODebugMapParser.cpp?rev=225386&r1=225385&r2=225386&view=diff
> ==============================================================================
> --- llvm/trunk/tools/dsymutil/MachODebugMapParser.cpp (original)
> +++ llvm/trunk/tools/dsymutil/MachODebugMapParser.cpp Wed Jan  7 15:13:30 2015
> @@ -24,7 +24,8 @@ public:
>   MachODebugMapParser(StringRef BinaryPath, StringRef PathPrefix = "",
>                       bool Verbose = false)
>       : BinaryPath(BinaryPath), PathPrefix(PathPrefix),
> -        MainBinaryHolder(Verbose), CurrentObjectHolder(Verbose) {}
> +        MainBinaryHolder(Verbose), CurrentObjectHolder(Verbose),
> +        CurrentDebugMapObject(nullptr) {}
> 
>   /// \brief Parses and returns the DebugMap of the input binary.
>   /// \returns an error in case the provided BinaryPath doesn't exist
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list