[llvm] r225319 - cmake: Add 'examples' target

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed Jan 7 11:05:21 PST 2015


> On 2015-Jan-07, at 06:49, Aaron Ballman <aaron at aaronballman.com> wrote:
> 
> On Wed, Jan 7, 2015 at 9:41 AM, Duncan Exon Smith <dexonsmith at apple.com> wrote:
>> Hmm... looks like those commits only make sense for make/ninja, not for IDEs.  I was too optimistic.
>> 
>> If you know what's wrong and can fix it, please go ahead.  Otherwise those commits should just be reverted.  I'll revert myself in a few hours when I get to work if you haven't replied.
> 
> I think what's wrong is that we already have a folder named Examples,
> and winds up adding a target with the same name. This could be as
> simple to fix as picking a new name for the custom target, but I'm not
> enough of a CMake expert to really say whether that's the right fix or
> not.
> 
> I've reverted in r225355 for now, which gets MSVC to load the
> generated solution without errors.

Thanks for the revert.  Chandler suggested renaming to `llvm-examples`
and making `examples` an umbrella target that calls out to `llvm-` and
`clang-` (and potentially other) prefixes... maybe instead
`examples-all` would do the trick.  When I get back to this (not high
priority TBH) I'll try something along those lines.



More information about the llvm-commits mailing list