[PATCH] [CodeGen] Add iterator ranges for the MVT::SimpleValueType enum.

Ahmed Bougacha ahmed.bougacha at gmail.com
Wed Jan 7 10:42:13 PST 2015


On Tue, Jan 6, 2015 at 1:16 PM, Pete Cooper <peter_cooper at apple.com> wrote:
> Hi Ahmed
>
> LGTM with just one change:
>
> +      return mvt_range((MVT::SimpleValueType)0, MVT::LAST_VALUETYPE);
>
> Please add FIRST_VALUETYPE to MVT so that you can use enums on the above line instead of 0.  I doubt MVT will ever start from anything other than 0, but its just best to avoid there ever being an issue.

Good point, r225362.
I'll commit the rest later, with one additional change: renaming the
new _types methods to _valuetypes, to stay consistent with the rest of
MVT.

Pete, Hal, thanks for reviewing,

-Ahmed

> Thanks,
> Pete
>> On Jan 6, 2015, at 1:06 PM, Ahmed Bougacha <ahmed.bougacha at gmail.com> wrote:
>>
>> And another, post-holiday, ping!
>>
>>
>> http://reviews.llvm.org/D6537
>>
>> Files:
>>  include/llvm/CodeGen/MachineValueType.h
>>  lib/Target/X86/X86ISelLowering.cpp
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list