[PATCH] builtins: avoid duplicating unwind declarations

Saleem Abdulrasool compnerd at compnerd.org
Wed Jan 7 08:15:44 PST 2015


Yes, the additional change of only including it is intentional.  However, keep in mind that the header is compiler provided, so you can build this even if you only have a clang installation or if you are building it standalone with a separate copy of libunwind.


================
Comment at: lib/builtins/gcc_personality_v0.c:148
@@ -187,3 +147,3 @@
          uint64_t exceptionClass, struct _Unwind_Exception* exceptionObject,
-         _Unwind_Context_t context)
+         struct _Unwind_Context *context)
 #else
----------------
rengolin wrote:
> This change doesn't seem relevant (even if it is correct) to this patch.
Speling change.  _Unwind_Context_t was a typedef for struct _Unwind_Context *.

http://reviews.llvm.org/D6822

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list