[PATCH] Introduce an example statepoint GC strategy

Philip Reames listmail at philipreames.com
Mon Jan 5 10:43:17 PST 2015


================
Comment at: lib/CodeGen/StatepointExampleGC.cpp:1
@@ +1,2 @@
+//===-- StatepointDefaultGC.cpp - The default statepoint GC strategy ------===//
+//
----------------
artagnon wrote:
> Perhaps rename this to StatepointGC, to look like ErlangGC and OCamlGC?
> Also, you need a `llvm::linkStatepointGC() { }` for anyone to use it. Please see "introduce link_gc_components" for an example of the work going in this direction.
It looks like I do need to update the file comment to the new name.

I would strongly prefer to keep the current name.  This is *specifically* an example.  It is not tied to any external GC.  The Ocaml and Erlang ones have external dependences.

As for your second point, see line 53 in this file.

http://reviews.llvm.org/D6808

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list