[PATCH] [dsymutil] Implement the BinaryHolder object and gain archive support.

Alexey Samsonov vonosmas at gmail.com
Mon Jan 5 10:13:05 PST 2015


================
Comment at: tools/dsymutil/BinaryHolder.h:75
@@ +74,3 @@
+  /// the BinaryHolder.
+  ErrorOr<const object::ObjectFile &> GetObjectFile(StringRef Filename);
+
----------------
friss wrote:
> samsonov wrote:
> > Does it need to be a public method?
> Not in this version of the patch, but I don't see a compelling reason to make it private. Consumers that don't care about the object file type should call this method (the Dwarf linker is one of these consumers). Any strong objection to leaving it public?
No, not really. Feel free to leave it public.

http://reviews.llvm.org/D6690

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list