[PATCH] [lld] ELF: Support detection of relocation errors during processing

Will Newton will.newton at linaro.org
Mon Jan 5 03:02:50 PST 2015


On 2 January 2015 at 18:27, Shankar Kalpathi Easwaran
<shankarke at gmail.com> wrote:
> REPOSITORY
>   rL LLVM
>
> ================
> Comment at: lib/Core/Error.cpp:122
> @@ +121,3 @@
> +  return o;
> +}
> +
> ----------------
> I think we should move this error category inside ELF.

I started out structuring the code that way. It causes a problem
though as the ELF code which defines the error category then gets
linked before the ELF architecture backend code which uses it so there
is an undefined symbol. We could add some kind of "ELF backend
support" library that is linked after the backend code to fix this but
in the end it seemed easier and more natural to keep all the errors in
one place in Core.

I am glad to hear from Saleem that it would be useful for PE/COFF too.

> http://reviews.llvm.org/D6827
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>



-- 
Will Newton
Toolchain Working Group, Linaro



More information about the llvm-commits mailing list