[PATCH] [lld] ELF: Support detection of relocation errors during processing

[Will Newton]

On 2 January 2015 at 17:32, Simon Atanasyan <simon at atanasyan.com> wrote:
> REPOSITORY
>   rL LLVM
>
> ================
> Comment at: lib/ReaderWriter/ELF/SectionChunks.h:418
> @@ +417,3 @@
> +                                                          *ai, *ref)) {
> +        printError(EC.message(), *ai, *ref);
> +        success = false;
> ----------------
> Now `parallel_for_each` does all tasks in the single thread. But in the future the body of this loop can be parallelized. Does the `printError` ready to be called from multiple threads?

I had that issue on my mental todo list but sort of pushed it to one
side. Is there a good way to output messages from threads in the
current infrastructure? I can switch to using e.g. Twine to build the
error message and output it in one go. errs is unbuffered but it is
not clear to me (yet) whether this is sufficient to guarantee that
output is not interleaved.

> http://reviews.llvm.org/D6827
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>



-- 
Will Newton
Toolchain Working Group, Linaro